-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user labels and labels to monitoring notification channel DS #3005
Add user labels and labels to monitoring notification channel DS #3005
Conversation
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
3079a9e
to
651bcae
Compare
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
651bcae
to
ebe099f
Compare
Also fix a test --> Fixes hashicorp/terraform-provider-google#5452
The data source fails if multiple channels of a type exist, so a test that only tests type will fail if any dangling resources exist with the same type, or any tests with a same type are running concurrently. Thus, we have two type tests that test with labels to try to cover this, so we don't run into test errors. I think the real solution is that we should add/replace this with a data source allowing for listing multiple channels.
Also changed some urls/emails to be safer-ish.
Release Note Template for Downstream PRs (will be copied)