Fix identity platform default_supported_idp_config idp_id #2969
Conversation
slevenick
changed the title
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in Ansible. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
| @@ -1,5 +1,6 @@ | |||
| resource "google_identity_platform_default_supported_idp_config" "<%= ctx[:primary_resource_id] %>" { | |||
| enabled = true | |||
| client_id = "playgames.google.com" | |||
| idp_id = "playgames.google.com" | |||
There was a problem hiding this comment.
Does this mean that anyone who previously configured GCIP will now have to change their config?
There was a problem hiding this comment.
Yes I don't believe anyone could have successfully configured their IDP config with the client_id and the idp_id as the same value. Generally the client_id would be a generated value, so the API accepts any value, but the correct value would need to be issued by the IDP that is being used for authentication (playgames.google.com in this case).
At least that's my (likely incomplete) understanding of OAuth at this point
…p_id and client_id fields
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
idp-fix
branch
from
251fd1d to
9734346
Compare
Fixes: hashicorp/terraform-provider-google#5390
Allows for
idp_idandclient_idfields to be configured separately.Release Note Template for Downstream PRs (will be copied)