Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff suppress timestamp for dataproc cluster autoDeleteTime #2959

Merged
merged 7 commits into from
Jan 13, 2020
Merged

Diff suppress timestamp for dataproc cluster autoDeleteTime #2959

merged 7 commits into from
Jan 13, 2020

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Jan 10, 2020 •
edited
Loading

Also add docs for #2926
Skipping release note since we haven't released ^^ yet

Fixes hashicorp/terraform-provider-google#5378

@emilymye emilymye mentioned this pull request Jan 10, 2020
Closed
@emilymye emilymye requested review from megan07 and chrisst January 10, 2020 22:12
megan07
megan07 reviewed Jan 10, 2020
View reviewed changes
third_party/terraform/website/docs/r/dataproc_cluster.html.markdown Outdated
```

* `idle_delete_ttl` - (Optional) The duration to keep the cluster alive while idling
(no jobs running). After this TTL, the cluster will to be deleted. Valid range: [10m, 14d].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(no jobs running). After this TTL, the cluster will to be deleted. Valid range: [10m, 14d].
(no jobs running). After this TTL, the cluster will be deleted. Valid range: [10m, 14d].

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 10319a8.

Pull request statuses

No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1629
depends: GoogleCloudPlatform/terraform-google-conversion#320
depends: hashicorp/terraform-provider-google#5379
depends: ansible-collections/google.cloud#133

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, c922b15.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 796e85a.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, e250ecb.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/inspec-gcp#303

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, c5d3860.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician modular-magician merged commit c8733d3 into GoogleCloudPlatform:master Jan 13, 2020
@modular-magician modular-magician mentioned this pull request Jan 29, 2020
Closed
This was referenced Jan 29, 2020
Closed
Closed
Closed
Closed
This was referenced Feb 12, 2020
Closed
Closed
Closed
@modular-magician modular-magician mentioned this pull request Mar 4, 2020
Closed
This was referenced Mar 18, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megan07 megan07 megan07 approved these changes

@chrisst chrisst Awaiting requested review from chrisst

Assignees
No one assigned
Labels
ansible automerged cla: yes downstream-generated inspec terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix TestAccDataprocCluster_withLifecycleConfigAutoDeletion
4 participants
@emilymye @modular-magician @megan07 @googlebot