Add validation for start_time to resource_policy #2940
Conversation
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in Ansible. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
| func validateHourlyOnly(val interface{}, key string) (warns []string, errs []error) { | ||
| v := val.(string) | ||
| parts := strings.Split(v, ":") | ||
| if len(parts) != 2 { |
There was a problem hiding this comment.
Feel free to ignore this but we also might as well verify the hour is between 0 and 23 at this point? Part of me thinks you should make this a regexp match or do time.Parse("15:04", v) (even though I hate how they make you define a custom format)
There was a problem hiding this comment.
we don't have to validate hours because the api will reject bad inputs there whereas the minutes it would accept and silently transform. But it's probably worth throwing it in anyway.
re: time.parse or regex - it's going to be a significantly more complex operation to use either of those over string splitting and casting to ints and I don't think either strategy provides added value in readability or flexibility.
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
issue-4611
branch
from
c9d8ee3 to
cdacf6e
Compare
Fixes hashicorp/terraform-provider-google#4611
Release Note Template for Downstream PRs (will be copied)