Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark removed fields as computed #2910

Merged
merged 2 commits into from
Jan 6, 2020

Conversation

danawillow
Copy link
Contributor

As per guidelines at https://www.terraform.io/docs/extend/best-practices/deprecations.html.

Fixes hashicorp/terraform-provider-google#5265.

Release Note Template for Downstream PRs (will be copied)

all: fixed issue where many fields that were removed in 3.0.0 would show a diff when they were removed from config

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, cd13a00.

Pull request statuses

WARNING: The following files changed in commit cd13a00 may need corresponding changes in third_party/validator:

  • third_party/terraform/resources/resource_storage_bucket.go

No diff detected in terraform-google-conversion.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1585
depends: hashicorp/terraform-provider-google#5313
depends: ansible-collections/google.cloud#121

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, e5a4078.

Pull request statuses

WARNING: The following files changed in commit e5a4078 may need corresponding changes in third_party/validator:

  • third_party/terraform/resources/resource_storage_bucket.go

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@danawillow danawillow requested a review from chrisst January 4, 2020 00:14
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 626cccd into GoogleCloudPlatform:master Jan 6, 2020
@danawillow danawillow deleted the tf-5265 branch January 6, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_container_node_pool incorrectly recreating
4 participants