Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test domain for Cloud Run Domain Mapping #2899

Merged
merged 3 commits into from
Dec 30, 2019
Merged

Fix test domain for Cloud Run Domain Mapping #2899

merged 3 commits into from
Dec 30, 2019

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye requested a review from chrisst December 30, 2019 17:53
@emilymye emilymye requested a review from danawillow December 30, 2019 17:53
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 2d461ba.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1570
depends: hashicorp/terraform-provider-google#5279

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 01970b9.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, cd91474.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

emilymye and others added 3 commits December 30, 2019 18:50
@emilymye @modular-magician
fix test domain
f8d3785
@emilymye @modular-magician
disable metrics lint check for this mapping
08fe227
@modular-magician
Update tracked submodules -> HEAD on Mon Dec 30 18:50:15 UTC 2019
cf83ddd 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit ed947a9 into GoogleCloudPlatform:master Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisst chrisst chrisst approved these changes

@danawillow danawillow Awaiting requested review from danawillow

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix TestAccCloudRunDomainMapping_cloudRunDomainMappingBasicExample
4 participants
@emilymye @modular-magician @chrisst @googlebot