Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll domain mapping until it succeeds #2891

Merged

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Dec 27, 2019

Tests should have been failing and it would have shown that #2889 was an issue.

Release Note Template for Downstream PRs (will be copied)

`cloud_run`: Changed `cloud_run_domain_mapping` to poll for success or failure and throw an appropriate error when ready status returns as false.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, cf52313.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1564
depends: hashicorp/terraform-provider-google#5267

chrisst and others added 2 commits December 27, 2019 19:58
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 44d5adf into GoogleCloudPlatform:master Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants