Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GKE to resume create after interruption #2857

Merged

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Dec 18, 2019

GKE takes a while to create but if the Terraform process is interrupted during
the create it will exit before capturing any of the state and subsequent applys
would try to create an already created cluster. This change will gracefully
terminate the create call by persisting the operation id to state if the create
call hasn't succeeded yet. Running plan again will use the operation id to
resume polling the operation until success or failure.

upstreaming https://github.com/terraform-providers/terraform-provider-google/pull/5197/files

Release Note Template for Downstream PRs (will be copied)

`compute`: Added graceful termination to `container_cluster` create calls so that partially created clusters will resume the original operation if the Terraform process is killed mid create.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 592b31a.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1533
depends: GoogleCloudPlatform/terraform-google-conversion#296
depends: hashicorp/terraform-provider-google#5217

@chrisst chrisst force-pushed the resuming-interrupted-gke branch from 592b31a to 661fa91 Compare December 19, 2019 00:48
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 661fa91.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@chrisst chrisst force-pushed the resuming-interrupted-gke branch from 661fa91 to 9da87d3 Compare December 19, 2019 01:14
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 9da87d3.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

chrisst and others added 2 commits December 19, 2019 01:34
GKE takes a while to create but if the Terraform process is interrupted during
the create it will exit before capturing any of the state and subsequent applys
would try to create an already created cluster. This change will gracefully
terminate the create call by persisting the operation id to state if the create
call hasn't succeeded yet. Running plan again will use the operation id to
resume polling the operation until success or failure.
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants