Support for Identity Platform #2840

slevenick · 2019-12-17T00:16:32Z

Adds support for Google Cloud Identity Platform resources

Fixes: hashicorp/terraform-provider-google#5048

Release Note Template for Downstream PRs (will be copied)

`google_identity_platform_tenant`

`google_identity_platform_oauth_idp_config`

`google_identity_platform_tenant_oauth_idp_config`

`google_identity_platform_tenant_inbound_saml_config`

`google_identity_platform_inbound_saml_config`

`google_identity_platform_tenant_default_supported_idp_config`

`google_identity_platform_default_supported_idp_config`

modular-magician · 2019-12-17T00:26:11Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 7a0012e.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1523
depends: GoogleCloudPlatform/terraform-google-conversion#295
depends: hashicorp/terraform-provider-google#5199

modular-magician · 2019-12-17T17:44:22Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5cc0a23.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-12-17T17:45:01Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5cc0a23.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-12-17T17:55:55Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 1f2a394.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-12-17T18:06:40Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 254d8f7.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

slevenick · 2019-12-17T18:25:16Z

Fixes: hashicorp/terraform-provider-google#5048

modular-magician · 2019-12-17T19:22:42Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 024bc0e.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-12-18T00:46:25Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 349ae39.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-12-18T01:11:24Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b5b5743.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

danawillow

Looks good overall, just some nits/questions. In the future, it would probably be better to split PRs like this up into a few smaller ones since it's a fair bit of YAML (and a lot of generated code) to review.

products/identityplatform/api.yaml

danawillow · 2019-12-18T18:06:20Z

products/identityplatform/api.yaml

+          The name of the InboundSamlConfig resource. Must start with 'saml.' and can only have alphanumeric characters,
+          hyphens, underscores or periods. The part after 'saml.' must also start with a lowercase letter, end with an
+          alphanumeric character, and have at least 2 characters.
+        required: true


The docs for name say Ignored during create requests and that they're of the projects/x/thing/id form. Are they just blatantly wrong?

I've added a name_from_self_link flattener to this field via terraform.yaml so the form will be more usable.

I believe the name in the body is ignored in the create request, but the shortened name is used in the create_url. It might technically be a url_param_only, but that prevents reading

It should be input though, I'll add that

products/identityplatform/api.yaml

danawillow · 2019-12-18T18:24:23Z

products/identityplatform/api.yaml

+      - !ruby/object:Api::Type::Boolean
+        name: 'enabled'
+        description: |
+          If allows users to sign in with the provider.


nit: this is kind of awkward phrasing

Suggested change

If allows users to sign in with the provider.

If this config allows users to sign in with the provider.

products/identityplatform/api.yaml

templates/terraform/examples/identity_platform_default_supported_idp_config_basic.tf.erb

templates/terraform/examples/identity_platform_tenant_default_supported_idp_config_basic.tf.erb

modular-magician · 2019-12-18T21:24:20Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 1ac4a79.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

danawillow

LGTM, though I wouldn't mind seeing more update tests. Since we're also in contact with the GCIP team, it might be worth getting their eyes on this too to make sure this was what they're looking for.

modular-magician · 2019-12-18T23:49:27Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, fb0a336.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-12-19T00:04:58Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 2c70482.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

…leton updates

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

googlebot added the cla: yes label Dec 17, 2019

slevenick changed the title ~~GCIP~~ Support for Identity Platform Dec 17, 2019

modular-magician added downstream-generated terraform-google-conversion terraform-provider-google-beta terraform-provider-google labels Dec 17, 2019

slevenick force-pushed the gcip branch from 65b9b75 to 5cc0a23 Compare December 17, 2019 17:34

slevenick requested a review from danawillow December 18, 2019 00:46

slevenick force-pushed the gcip branch from 349ae39 to b5b5743 Compare December 18, 2019 00:58

danawillow suggested changes Dec 18, 2019

View reviewed changes

slevenick requested a review from danawillow December 18, 2019 21:29

danawillow approved these changes Dec 18, 2019

View reviewed changes

modular-magician added the automerged label Dec 27, 2019

slevenick added 5 commits December 27, 2019 19:32

First pass at idp config basic

30e0414

Adding new resource

d66742f

Adding saml config

4eb80aa

Adding tests, failing due to project/firebase issues

797b32c

Creating project for idp tests

538bf22

slevenick and others added 12 commits December 27, 2019 19:32

Add tenant, oauth idp config

e7337f5

Add tenant gcip configs

1a42ebe

Rename folder to identityplatform, add to website.erb

2df9a35

Skip basic idp default test, let update test work instead due to sing…

6a97e72

…leton updates

Add destroy to handwritten test

a18fdfa

Imports

f6d596a

Adding notes about enabling identity platform

4c78720

Comments

214e4fb

PR feedback

0941092

Add handwritten update tests

67d6598

Add back deleted method

74dbaaa

Update tracked submodules -> HEAD on Fri Dec 27 19:32:54 UTC 2019

f8160a5

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician force-pushed the gcip branch from 2c70482 to f8160a5 Compare December 27, 2019 19:33

modular-magician merged commit fb78675 into GoogleCloudPlatform:master Dec 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for Identity Platform #2840

Support for Identity Platform #2840

slevenick commented Dec 17, 2019 •

edited

Loading

modular-magician commented Dec 17, 2019

modular-magician commented Dec 17, 2019

modular-magician commented Dec 17, 2019

modular-magician commented Dec 17, 2019

modular-magician commented Dec 17, 2019

slevenick commented Dec 17, 2019

modular-magician commented Dec 17, 2019

modular-magician commented Dec 18, 2019

modular-magician commented Dec 18, 2019

danawillow left a comment

danawillow Dec 18, 2019

slevenick Dec 18, 2019

danawillow Dec 18, 2019

modular-magician commented Dec 18, 2019

danawillow left a comment

modular-magician commented Dec 18, 2019

modular-magician commented Dec 19, 2019

	If allows users to sign in with the provider.
	If this config allows users to sign in with the provider.

Support for Identity Platform #2840

Support for Identity Platform #2840

Conversation

slevenick commented Dec 17, 2019 • edited Loading

modular-magician commented Dec 17, 2019

Pull request statuses

New Pull Requests

modular-magician commented Dec 17, 2019

Pull request statuses

New Pull Requests

modular-magician commented Dec 17, 2019

Pull request statuses

New Pull Requests

modular-magician commented Dec 17, 2019

Pull request statuses

New Pull Requests

modular-magician commented Dec 17, 2019

Pull request statuses

New Pull Requests

slevenick commented Dec 17, 2019

modular-magician commented Dec 17, 2019

Pull request statuses

New Pull Requests

modular-magician commented Dec 18, 2019

Pull request statuses

New Pull Requests

modular-magician commented Dec 18, 2019

Pull request statuses

New Pull Requests

danawillow left a comment

Choose a reason for hiding this comment

danawillow Dec 18, 2019

Choose a reason for hiding this comment

slevenick Dec 18, 2019

Choose a reason for hiding this comment

danawillow Dec 18, 2019

Choose a reason for hiding this comment

modular-magician commented Dec 18, 2019

Pull request statuses

New Pull Requests

danawillow left a comment

Choose a reason for hiding this comment

modular-magician commented Dec 18, 2019

Pull request statuses

New Pull Requests

modular-magician commented Dec 19, 2019

Pull request statuses

New Pull Requests

slevenick commented Dec 17, 2019 •

edited

Loading