Update inspec container for new rubocop and terraform versions #2826

slevenick · 2019-12-12T18:21:36Z

Rubocop updated and broke unit tests because the cop names changed

modular-magician · 2019-12-12T18:31:31Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 6130258.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#5158

modular-magician · 2019-12-12T19:20:52Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 55b89d5.

Pull request statuses

No diff detected in terraform-provider-google-beta.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: GoogleCloudPlatform/terraform-google-conversion#293

modular-magician · 2019-12-12T20:36:06Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 243dfaa.

Pull request statuses

No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1509

modular-magician · 2019-12-12T23:15:04Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5bcd5ef.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: ansible-collections/google.cloud#114

modular-magician · 2019-12-12T23:24:45Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 294892e.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-12-13T00:18:16Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, ca3da0a.

Pull request statuses

No diff detected in terraform-google-conversion.
Ansible already has an open PR.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1512
depends: hashicorp/terraform-provider-google#5167
depends: modular-magician/inspec-gcp#285

modular-magician · 2019-12-13T00:35:19Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 4d986f9.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-12-13T21:06:46Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 50764da.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-12-13T21:08:08Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 50764da.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

…examples

This is excluded from rubocop, so go back to normal `{}` as this is compiled into terraform files

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

googlebot added the cla: yes label Dec 12, 2019

modular-magician added downstream-generated terraform-provider-google labels Dec 12, 2019

slevenick force-pushed the update-inspec-container branch from 6130258 to 55b89d5 Compare December 12, 2019 19:10

modular-magician added the terraform-google-conversion label Dec 12, 2019

modular-magician added the terraform-provider-google-beta label Dec 12, 2019

modular-magician added the ansible label Dec 12, 2019

slevenick force-pushed the update-inspec-container branch from 784a177 to f530aca Compare December 12, 2019 23:43

modular-magician added the inspec label Dec 13, 2019

slevenick requested a review from rambleraptor December 13, 2019 00:46

rambleraptor approved these changes Dec 13, 2019

View reviewed changes

modular-magician added the automerged label Dec 13, 2019

slevenick added 9 commits December 13, 2019 21:44

Update inspec container for new rubocop and terraform versions

35a2436

Add rubocop version pin to gemfile

35f8e4b

Update rubocop in MM Gemfile

dbecc4b

Updating ci containers

bd81701

Add Gemfile.lock

1c5feef

Update rubocop to 0.77.0

5d6370b

Update rubocop to .77.0

7919acb

Exclude more of the file for things that are compiled into terraform …

6b3af98

…examples

Missed revert in examples

fecd52a

This is excluded from rubocop, so go back to normal `{}` as this is compiled into terraform files

slevenick and others added 2 commits December 13, 2019 21:44

Missed a s

c33a918

Update tracked submodules -> HEAD on Fri Dec 13 21:44:58 UTC 2019

318c511

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician force-pushed the update-inspec-container branch from 50764da to 318c511 Compare December 13, 2019 21:45

modular-magician merged commit 6ba1754 into GoogleCloudPlatform:master Dec 13, 2019

This was referenced Feb 12, 2020

New GCP module: gcp_bigtable_instance ansible/ansible#67332

Closed

New GCP module: gcp_bigtable_instance_info ansible/ansible#67333

Closed

Bug fixes for GCP (as of 2019-11-14T07:04:56Z) ansible/ansible#67562

Closed

modular-magician mentioned this pull request Mar 4, 2020

New GCP module: gcp_storage_default_object_acl ansible/ansible#67988

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update inspec container for new rubocop and terraform versions #2826

Update inspec container for new rubocop and terraform versions #2826

slevenick commented Dec 12, 2019

modular-magician commented Dec 12, 2019

modular-magician commented Dec 12, 2019

modular-magician commented Dec 12, 2019

modular-magician commented Dec 12, 2019

modular-magician commented Dec 12, 2019

modular-magician commented Dec 13, 2019

modular-magician commented Dec 13, 2019

modular-magician commented Dec 13, 2019

modular-magician commented Dec 13, 2019

Update inspec container for new rubocop and terraform versions #2826

Update inspec container for new rubocop and terraform versions #2826

Conversation

slevenick commented Dec 12, 2019

modular-magician commented Dec 12, 2019

Pull request statuses

New Pull Requests

modular-magician commented Dec 12, 2019

Pull request statuses

New Pull Requests

modular-magician commented Dec 12, 2019

Pull request statuses

New Pull Requests

modular-magician commented Dec 12, 2019

Pull request statuses

New Pull Requests

modular-magician commented Dec 12, 2019

Pull request statuses

New Pull Requests

modular-magician commented Dec 13, 2019

Pull request statuses

New Pull Requests

modular-magician commented Dec 13, 2019

Pull request statuses

New Pull Requests

modular-magician commented Dec 13, 2019

Pull request statuses

New Pull Requests

modular-magician commented Dec 13, 2019

Pull request statuses

New Pull Requests