do not retry if sql api returns 409 for deleted instance name #2817
Conversation
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
| @@ -33,6 +33,10 @@ func pubsubTopicProjectNotReady(err error) (bool, string) { | |||
|
|
|||
| func isSqlOperationInProgressError(err error) (bool, string) { | |||
| if gerr, ok := err.(*googleapi.Error); ok && gerr.Code == 409 { | |||
| if strings.Contains(gerr.Body, "you cannot reuse the name of the deleted instance until one week from the deletion date.") { | |||
There was a problem hiding this comment.
hmmm, i don't like this, but I'm not sure if we have a better option
There was a problem hiding this comment.
I agree, I could use a smaller portion of the message, in case it were to change, but I'm not sure where to cut it off. I wasn't sure what else to key off of, because it's only the message that differentiates it from other 409s
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
megan_sql_instance_409
branch
from
7f91485 to
dd49d30
Compare
Fixes hashicorp/terraform-provider-google#5101
Release Note Template for Downstream PRs (will be copied)