Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor InSpec terraform file #2813

Merged
merged 4 commits into from
Dec 13, 2019
Merged

Refactor InSpec terraform file #2813

merged 4 commits into from
Dec 13, 2019

Conversation

slevenick
Copy link
Contributor

Now matches 0.12 syntax so we won't get as many warning messages

Release Note Template for Downstream PRs (will be copied)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 3df1e67.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/inspec-gcp#274

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 17b591e.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 50212d3.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 800fe61.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

slevenick and others added 4 commits December 13, 2019 17:35
@modular-magician modular-magician merged commit 78b3d2c into GoogleCloudPlatform:master Dec 13, 2019
emilymye pushed a commit to emilymye/magic-modules that referenced this pull request Dec 13, 2019
@nat-henderson @modular-magician
Add monitoring-read scope, upstreaming TPG GoogleCloudPlatform#2813. (G…
6b06e02 
…oogleCloudPlatform#2389)

Merged PR GoogleCloudPlatform#2389.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

@rambleraptor rambleraptor Awaiting requested review from rambleraptor

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated inspec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slevenick @modular-magician @rileykarson @googlebot