Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Cloud Run metadata block to be optional #2793

Merged

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Dec 6, 2019

The create request doesn't actually require this field. Unfortunately this probably should have been a purely computed field, but I'll file a 4.0 change for this.

Release Note Template for Downstream PRs (will be copied)

`cloudrun`: Stop requiring the root `metadata` block for `google_cloud_run_service`.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, d3ae91b.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1478
depends: GoogleCloudPlatform/terraform-google-conversion#279
depends: hashicorp/terraform-provider-google#5094

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Namespace was already being inferred from the project, right? This just made it so you don't have to set the metadata block at all.

templates/terraform/encoders/cloud_run_service.go.erb Outdated Show resolved Hide resolved
@chrisst chrisst changed the title Allow namespace to be inferred from project Allow Cloud Run metadata block to be optional Dec 6, 2019
@chrisst chrisst force-pushed the cloudrun-followup2 branch from d3ae91b to f82e4e9 Compare December 6, 2019 18:03
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, f82e4e9.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 5eb989d into GoogleCloudPlatform:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants