Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add route_rules to UrlMap for Traffic Director #2748

Merged
merged 5 commits into from
Dec 6, 2019
Merged

Add route_rules to UrlMap for Traffic Director #2748

merged 5 commits into from
Dec 6, 2019

Conversation

tysen
Copy link

@tysen tysen commented Nov 25, 2019

Release Note Template for Downstream PRs (will be copied)

`google_compute_url_map` now supports header actions and route rules.

@tysen tysen requested a review from rileykarson November 25, 2019 23:21
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 4b0a0cd.

Pull request statuses

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1435
depends: GoogleCloudPlatform/terraform-google-conversion#269
depends: hashicorp/terraform-provider-google#4992
depends: ansible-collections/google.cloud#95
depends: modular-magician/inspec-gcp#256

rileykarson
rileykarson reviewed Dec 2, 2019
View reviewed changes
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a pass of resource schema. For repeated headerAction blocks, any comments on the first apply to the rest.

products/compute/api.yaml Outdated Show resolved Hide resolved
products/compute/api.yaml Show resolved Hide resolved
products/compute/api.yaml Show resolved Hide resolved
products/compute/api.yaml Show resolved Hide resolved
templates/terraform/examples/url_map_traffic_director_route.tf.erb Show resolved Hide resolved
products/compute/api.yaml Show resolved Hide resolved
products/compute/api.yaml
Specifies the retry policy associated with this route.
properties:
- !ruby/object:Api::Type::Integer
name: 'numRetries'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are this & the below value required? Do they take on defaults when not specified?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the docs for perTryTimeout and made numRetries required.

products/compute/api.yaml
the matched service
properties:
- !ruby/object:Api::Type::String
name: 'hostRewrite'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value must be between 1 and 255 characters. suggests the field is Required?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. There are different portions of the URL that can be replaced (host, path, and prefix) and none are required.

products/compute/api.yaml Show resolved Hide resolved
products/compute/api.yaml Show resolved Hide resolved
@tysen tysen requested a review from rileykarson December 2, 2019 23:51
rileykarson
rileykarson reviewed Dec 4, 2019
View reviewed changes
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, can you structure changes based on review comments as separate commits? It's hard to see the diff of the changes when they've been squashed in, and means I have to look over the entire original change and try and remember what it looked like before. https://github.com/GoogleCloudPlatform/magic-modules/compare/4b0a0cd45fa6d6a13eb709a2cbf163b888cf901b..b9ea89349df85fbebc6c96ad490d22b50a85c9ad makes it possible, but munges the changes with whatever you picked up from upstream.

A model I use a lot of the time is that I create a commit per-push including my changes (breaking it up more granularly if needed) and rebase+force push if I've fallen out of date with master.

products/compute/api.yaml Show resolved Hide resolved
products/compute/api.yaml Show resolved Hide resolved
@tysen tysen requested a review from rileykarson December 4, 2019 23:23
@rileykarson
Copy link
Member

Can you rebase + force-push so generation works again?

@tysen
Copy link
Author

tysen commented Dec 4, 2019

Done.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 63c7353.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

rileykarson
rileykarson reviewed Dec 6, 2019
View reviewed changes
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small comments left 🎉

products/compute/api.yaml Outdated Show resolved Hide resolved
products/compute/api.yaml
@@ -11509,6 +11513,8 @@ objects:
description: |
UrlMaps are used to route requests to a backend service based on rules
that you define for the host and path of an incoming URL.
references: !ruby/object:Api::Resource::ReferenceLinks
api: https://cloud.google.com/compute/docs/reference/rest/v1/urlMaps
async: !ruby/object:Api::OpAsync
operation: !ruby/object:Api::OpAsync::Operation
kind: 'compute#operation'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note for myself: GitHub is skipping a bunch of lines here with no indicator

third_party/terraform/tests/resource_compute_url_map_test.go.erb Show resolved Hide resolved
third_party/terraform/tests/resource_compute_url_map_test.go.erb Show resolved Hide resolved
@tysen tysen requested a review from rileykarson December 6, 2019 19:38
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 256cd6b.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 2ae35b2.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician modular-magician merged commit 1d93b45 into GoogleCloudPlatform:master Dec 6, 2019
@tysen tysen mentioned this pull request Dec 10, 2019
Merged
@modular-magician modular-magician mentioned this pull request Dec 10, 2019
Merged
@modular-magician modular-magician mentioned this pull request Dec 13, 2019
Merged
This was referenced Jan 29, 2020
Closed
Closed
Closed
Closed
Closed
This was referenced Feb 12, 2020
Closed
Closed
Closed
@modular-magician modular-magician mentioned this pull request Mar 4, 2020
Closed
This was referenced Mar 18, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
ansible automerged cla: yes downstream-generated inspec terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tysen @modular-magician @rileykarson @googlebot