Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for import format of only numbers in iam folder #2744

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented Nov 22, 2019

Fixes: hashicorp/terraform-provider-google#4971

google_folder import already behaves this way.

Release Note Template for Downstream PRs (will be copied)

`google_folder`: added support for importing in the form of the bare folder id, rather than requiring `folders/{bare_id}`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 6bfc4f9.

Pull request statuses

WARNING: The following files changed in commit 6bfc4f9 may need corresponding changes in third_party/validator:

  • third_party/terraform/utils/iam_folder.go

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1430
depends: hashicorp/terraform-provider-google#4981

slevenick and others added 3 commits November 22, 2019 23:24
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the iam-folder-import-formats branch from 6bfc4f9 to eab0dfe Compare November 22, 2019 23:24
@modular-magician modular-magician merged commit d4716f7 into GoogleCloudPlatform:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_folder_iam_policy import misbehaves if given a bare folder id
4 participants