Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark min_cpu_platform as computed in instance as it is returned #2743

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented Nov 22, 2019

This field seems to be returned by the API now, causing diffs if a user has not specified it

Fixes: hashicorp/terraform-provider-google#4975

Release Note Template for Downstream PRs (will be copied)

`google_compute_instance`: marked `min_cpu_platform` as computed so if it is not specified it will not cause diffs

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 2949c7a.

Pull request statuses

WARNING: The following files changed in commit 2949c7a may need corresponding changes in third_party/validator:

  • third_party/terraform/resources/resource_compute_instance.go

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1429
depends: hashicorp/terraform-provider-google#4980

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, though I'm confused why our tests didn't all fail. Any idea?

@slevenick
Copy link
Contributor Author

Tests didn't fail because this field is only set for certain machine types, specifically I've seen it come back on when the instance had a machine type of n2-standard-4. I believe this is because the n2 type only works on Cascade Lake architecture at the moment, so it somewhat makes sense to have that field set.

slevenick and others added 2 commits November 22, 2019 23:51
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_compute_instance : min_cpu_platform issue when setted to "empty"
4 participants