Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-NIC0 ILB support #2732

Merged
merged 1 commit into from
Nov 26, 2019
Merged

non-NIC0 ILB support #2732

merged 1 commit into from
Nov 26, 2019

Conversation

drebes
Copy link
Member

@drebes drebes commented Nov 21, 2019 •
edited
Loading

Release Note Template for Downstream PRs (will be copied)

`compute`: field `network` can now be specified on `google_compute_region_backend_service`, which allows internal load balancers to target the non-primary interface of an instance.

@drebes drebes requested a review from chrisst November 21, 2019 13:19
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, cb8eb06.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1418

chrisst
chrisst approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@chrisst chrisst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@chrisst
Copy link
Contributor

chrisst commented Nov 22, 2019

Looks like we'll need to update RegionBackendService as well. If you want to cobble onto this PR that would be great. Otherwise I'll just add an issue to track.

@drebes
Copy link
Member Author

drebes commented Nov 22, 2019

Not sure I follow, this is for RegionBackendService, which is the one used for internal load balancing. Do you mean BackendService instead?

@chrisst
Copy link
Contributor

chrisst commented Nov 23, 2019

Never mind, I had my chrome tabs backward 🤕 this is gtg

@modular-magician modular-magician merged commit 135b69a into GoogleCloudPlatform:master Nov 26, 2019
@drebes drebes deleted the ilb-multi-nic branch December 14, 2019 22:00
@danawillow danawillow mentioned this pull request Feb 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisst chrisst chrisst approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated enhancement terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drebes @modular-magician @chrisst @googlebot