Validate on deleted IAM members #2731

slevenick · 2019-11-20T23:56:06Z

Depends on
hashicorp/terraform-provider-google#4957
hashicorp/terraform-provider-google-beta#1416

Validates that members do not start with deleted:

Release Note Template for Downstream PRs (will be copied)

modular-magician · 2019-11-21T00:05:49Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, db252f8.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1417
depends: hashicorp/terraform-provider-google#4958

modular-magician · 2019-11-21T01:07:57Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, d52d3d9.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

danawillow

Did you also want to add this to binding and member?

danawillow · 2019-11-21T17:26:50Z

third_party/terraform/data_sources/data_source_google_iam_policy.go.erb

-							Elem:     &schema.Schema{Type: schema.TypeString},
+							Elem:     &schema.Schema{
+								Type:         schema.TypeString,
+								ValidateFunc: validation.StringDoesNotMatch(regexp.MustCompile("^deleted:"), "Terraform does not support deleted IAM members"),


Just to make it super extra clear, maybe something like "Terraform does not support IAM bindings for deleted users", so people don't get the wrong impression that they can't delete people from their policies.

modular-magician · 2019-11-21T17:40:57Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, d52d3d9.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-11-21T21:31:08Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5791fdd.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

danawillow

Looks good, looks also like TPG got a race condition so you'll probably need to regenerate before merging.

modular-magician · 2019-11-21T21:47:11Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5caf15e.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-11-22T18:10:12Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, ffaf8f3.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-11-22T18:20:12Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 88ad9f9.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

googlebot added the cla: yes label Nov 20, 2019

slevenick requested a review from danawillow November 20, 2019 23:56

modular-magician added downstream-generated terraform-provider-google-beta terraform-provider-google labels Nov 21, 2019

slevenick force-pushed the iam-deleted-members branch from db252f8 to d52d3d9 Compare November 21, 2019 00:57

danawillow reviewed Nov 21, 2019

View reviewed changes

danawillow approved these changes Nov 21, 2019

View reviewed changes

slevenick force-pushed the iam-deleted-members branch from 5791fdd to 5caf15e Compare November 21, 2019 21:36

slevenick force-pushed the iam-deleted-members branch from 5caf15e to ffaf8f3 Compare November 22, 2019 18:00

slevenick force-pushed the iam-deleted-members branch from ffaf8f3 to 88ad9f9 Compare November 22, 2019 18:10

modular-magician added the automerged label Nov 22, 2019

slevenick and others added 3 commits November 22, 2019 19:36

Validate on deleted members

510d635

Update validate note, add to iam_binding and iam_member

d819f81

Update tracked submodules -> HEAD on Fri Nov 22 19:36:48 UTC 2019

4ee4dfa

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician force-pushed the iam-deleted-members branch from 88ad9f9 to 4ee4dfa Compare November 22, 2019 19:36

modular-magician merged commit 79f8532 into GoogleCloudPlatform:master Nov 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validate on deleted IAM members #2731

Validate on deleted IAM members #2731

slevenick commented Nov 20, 2019

modular-magician commented Nov 21, 2019

modular-magician commented Nov 21, 2019

danawillow left a comment

danawillow Nov 21, 2019

modular-magician commented Nov 21, 2019

modular-magician commented Nov 21, 2019

danawillow left a comment

modular-magician commented Nov 21, 2019

modular-magician commented Nov 22, 2019

modular-magician commented Nov 22, 2019

Validate on deleted IAM members #2731

Validate on deleted IAM members #2731

Conversation

slevenick commented Nov 20, 2019

modular-magician commented Nov 21, 2019

Pull request statuses

New Pull Requests

modular-magician commented Nov 21, 2019

Pull request statuses

New Pull Requests

danawillow left a comment

Choose a reason for hiding this comment

danawillow Nov 21, 2019

Choose a reason for hiding this comment

modular-magician commented Nov 21, 2019

Pull request statuses

New Pull Requests

modular-magician commented Nov 21, 2019

Pull request statuses

New Pull Requests

danawillow left a comment

Choose a reason for hiding this comment

modular-magician commented Nov 21, 2019

Pull request statuses

New Pull Requests

modular-magician commented Nov 22, 2019

Pull request statuses

New Pull Requests

modular-magician commented Nov 22, 2019

Pull request statuses

New Pull Requests