Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add private instance support to data_fusion_instance #2719

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Nov 19, 2019

Release Note Template for Downstream PRs (will be copied)

`google_data_fusion_instance`: Added `private_instance` and `network_config` fields

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b8c48cf.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1411
depends: ansible-collections/google.cloud#93

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Not sure why the ansible diff exists, you can probably close it

products/datafusion/api.yaml Outdated Show resolved Hide resolved
@c2thorn c2thorn force-pushed the data-fusion-private-instances branch from 9e0627e to 0e4d6cf Compare November 19, 2019 22:46
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 0e4d6cf.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

c2thorn and others added 3 commits November 19, 2019 23:09
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the data-fusion-private-instances branch from 0e4d6cf to 6df57ec Compare November 19, 2019 23:09
@modular-magician modular-magician merged commit c22199c into GoogleCloudPlatform:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants