Refactor async class to support kubernetes objects #2718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splitting the Async class into 2 classes that inherit from the same base so that we can type sniff later in code to determine which type of async functionality should be used.
|
Mind deferring merging this until we're in consensus about the approach in #2716? |
rambleraptor
approved these changes
Nov 19, 2019
|
@rileykarson sure, the implementation of this is definitely tightly linked. |
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-provider-google-beta. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
closing in favor of upstream PR |
This was referenced Nov 27, 2019
This was referenced Dec 6, 2019
This was referenced Jan 29, 2020
This was referenced Feb 12, 2020
This was referenced Mar 18, 2020
This was referenced Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting the Async class into 2 classes that inherit from the same base so
that we can type sniff later in code to determine which type of async
functionality should be used.