Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requireAdminApproval/requireCorpOwned in AccessLevel's devicePolicy #2710

Merged
merged 2 commits into from
Nov 18, 2019

Conversation

drebes
Copy link
Member

@drebes drebes commented Nov 16, 2019

Release Note Template for Downstream PRs (will be copied)

supports `requireAdminApproval`/`requireCorpOwned` in `AccessLevel`'s `devicePolicy`.

@drebes
Copy link
Member Author

drebes commented Nov 16, 2019

Fixes GoogleCloudPlatform/magic-modules#2708

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, e99a30c.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1403
depends: GoogleCloudPlatform/terraform-google-conversion#263
depends: hashicorp/terraform-provider-google#4931

Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 8ef590c into GoogleCloudPlatform:master Nov 18, 2019
@drebes drebes deleted the corp-owned branch December 14, 2019 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants