Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retries to SQL user insert and update operations. #2703

Merged
merged 3 commits into from
Nov 22, 2019
Merged

Add retries to SQL user insert and update operations. #2703

merged 3 commits into from
Nov 22, 2019

Conversation

danawillow
Copy link
Contributor

Upstreams hashicorp/terraform-provider-google#4860.

Release Note Template for Downstream PRs (will be copied)

`sql`: added retries to `google_sql_user` create and update to reduce flakiness

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b72a9e5.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1399
depends: hashicorp/terraform-provider-google#4925

@danawillow danawillow requested a review from tysen November 15, 2019 23:15
@danawillow
Copy link
Contributor Author

Mind if I do those in a followup so the generated downstream stays the same as the original PR?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, f4d26c7.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#4927

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, f4d26c7.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

spew and others added 3 commits November 22, 2019 17:48
@spew @modular-magician
Add retries to SQL user insert and update operations.
ccb561e
@danawillow @modular-magician
Apply suggestions from code review
086b64b 
Co-Authored-By: Ty Larrabee <[email protected]>
@modular-magician
Update tracked submodules -> HEAD on Fri Nov 22 17:48:15 UTC 2019
16060b7 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 8f5e705 into GoogleCloudPlatform:master Nov 22, 2019
@danawillow danawillow deleted the tf-4860 branch November 22, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tysen tysen tysen approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danawillow @modular-magician @tysen @googlebot @spew