Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error instead of panicking if self link isn't long enough #2672

Merged

Conversation

rileykarson
Copy link
Member

Fixes hashicorp/terraform-provider-google#4886

Release Note Template for Downstream PRs (will be copied)

`compute`: `self_link` in several datasources will now error on invalid values instead of crashing

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 93923e0.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1373
depends: GoogleCloudPlatform/terraform-google-conversion#261
depends: hashicorp/terraform-provider-google#4887

@danawillow
Copy link
Contributor

Looks like the downstreams of this got merged, so merging this now.

rileykarson and others added 2 commits November 18, 2019 19:07
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 39d92c7 into GoogleCloudPlatform:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform crash with panic: runtime error: index out of range
5 participants