-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update upgrade guide #2665
update upgrade guide #2665
Changes from all commits
46ea178
f241ea1
997cf40
63fe939
d11eafe
0076758
0022969
f7574c0
70fb406
7bfe81e
7826c12
b12e7fe
d4d95e1
2444f22
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -272,7 +272,6 @@ objects: | |
properties: | ||
- !ruby/object:Api::Type::NestedObject | ||
name: template | ||
required: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this change intentional? Seems out of character with the rest of the changes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes! I took that out because i saw its all flattened in terraform.yaml, and the flattened part is already required. |
||
description: |- | ||
template holds the latest specification for the Revision to | ||
be stamped out. The template references the container image, and may also | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes actually don't do anything, because this resource is not currently generated. I removed the update from the upgrade guide, but I figured I could leave them all in here so that when we eventually do generate it, they'll be there.