Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If certificate_id is unset, it should not cause a diff. #2533

Merged

Conversation

nat-henderson
Copy link
Contributor

@nat-henderson nat-henderson commented Oct 24, 2019

Fixes hashicorp/terraform-provider-google#4741.

Release Note Template for Downstream PRs (will be copied)

`appengine`: Resolved permadiff in `google_app_engine_domain_mapping.ssl_settings.certificate_id`.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, a8af850.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1303
depends: hashicorp/terraform-provider-google#4754

@megan07
Copy link
Contributor

megan07 commented Oct 25, 2019

I think the beginning of the release note comment needs appengine:, but other than that I think this looks good!

nat-henderson and others added 2 commits October 25, 2019 20:23
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 5dd3616 into GoogleCloudPlatform:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_app_engine_domain_mapping AUTOMATIC certificate API is broken
4 participants