Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump GKE node pool GPU disk to an appropriate size. #2505

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Bump GKE node pool GPU disk to an appropriate size. #2505

merged 2 commits into from
Oct 22, 2019

Conversation

rileykarson
Copy link
Member

Fixes TestAccContainerNodePool_withGPU

Failing with:

Error: Error waiting for creating GKE NodePool: Google Compute Engine: Invalid value for field 'resource.properties.disks[0].initializeParams.diskSizeGb': '10'. Disk cannot be smaller than the chosen image 'gke-1147-gke10-cos-u-73-11647-293-0-v191004-pre-nvda-gpu' (15.0 GB).

Release Note Template for Downstream PRs (will be copied)

@rileykarson rileykarson requested a review from megan07 October 22, 2019 15:25
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 279c78c.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1285
depends: hashicorp/terraform-provider-google#4727

@modular-magician
Update tracked submodules -> HEAD on Tue Oct 22 15:55:06 UTC 2019
173c72d 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 49d3c3f into GoogleCloudPlatform:master Oct 22, 2019
JanMa pushed a commit to JanMa/magic-modules that referenced this pull request Oct 25, 2019
@rileykarson @JanMa
Bump GKE node pool GPU disk to an appropriate size. (GoogleCloudPlatf…
3bda179 
…orm#2505)

Merged PR GoogleCloudPlatform#2505.
JanMa added a commit to JanMa/magic-modules that referenced this pull request Oct 25, 2019
@JanMa
Revert "Bump GKE node pool GPU disk to an appropriate size. (GoogleCl…
4f124ca 
…oudPlatform#2505)"

This reverts commit 3bda179.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megan07 megan07 megan07 approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rileykarson @modular-magician @megan07 @googlebot