Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ip_configuration to dataflow_job #2504

Merged
merged 3 commits into from
Oct 22, 2019
Merged

add ip_configuration to dataflow_job #2504

merged 3 commits into from
Oct 22, 2019

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Oct 22, 2019

Fixes hashicorp/terraform-provider-google#4113

Release Note Template for Downstream PRs (will be copied)

`dataflow`: added `ip_configuration` option to `job`.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 84107d8.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1284
depends: hashicorp/terraform-provider-google#4726

@megan07 megan07 requested a review from danawillow October 22, 2019 14:49
danawillow
danawillow suggested changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the field to the docs as well?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 6b27c1c.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

megan07 and others added 3 commits October 22, 2019 16:45
@megan07 @modular-magician
add ip_configuration to dataflow_job
6cd6c33
@megan07 @modular-magician
update docs to include ip_configuration
2ff7bc4
@modular-magician
Update tracked submodules -> HEAD on Tue Oct 22 16:45:17 UTC 2019
4a50450 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the megan_dataflow_job_publicips branch from 6b27c1c to 4a50450 Compare October 22, 2019 16:45
@modular-magician modular-magician merged commit aa7ede4 into GoogleCloudPlatform:master Oct 22, 2019
JanMa pushed a commit to JanMa/magic-modules that referenced this pull request Oct 25, 2019
@megan07 @JanMa
add ip_configuration to dataflow_job (GoogleCloudPlatform#2504)
638f2f2 
Merged PR GoogleCloudPlatform#2504.
JanMa added a commit to JanMa/magic-modules that referenced this pull request Oct 25, 2019
@JanMa
Revert "add ip_configuration to dataflow_job (GoogleCloudPlatform#2504)"
f7d66e1 
This reverts commit 638f2f2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danawillow danawillow danawillow approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support for usePublicIps option in google_dataflow_job resource
4 participants
@megan07 @modular-magician @danawillow @googlebot