Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom flatten to transform json to string -> string map for params #2467

Merged
merged 4 commits into from
Oct 16, 2019
Merged

Add custom flatten to transform json to string -> string map for params #2467

merged 4 commits into from
Oct 16, 2019

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented Oct 14, 2019 •
edited
Loading

Fixes: hashicorp/terraform-provider-google#4669
Release Note Template for Downstream PRs (will be copied)

bigquery: fix issue with `google_bigquery_data_transfer_config` `params` crashing on boolean values

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, ddf6f03.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1263
depends: hashicorp/terraform-provider-google#4676

@slevenick slevenick requested a review from tysen October 14, 2019 23:28
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 4c32e56.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

tysen
tysen approved these changes Oct 15, 2019
View reviewed changes
Copy link

@tysen tysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may have an issue later with composite types.

@riccsnet riccsnet mentioned this pull request Oct 16, 2019
Closed
@modular-magician modular-magician force-pushed the bigquery-transfer-param-transform branch from 4c32e56 to 9c7a8dd Compare October 16, 2019 15:58
@modular-magician modular-magician merged commit cc0dc86 into GoogleCloudPlatform:master Oct 16, 2019
JanMa pushed a commit to JanMa/magic-modules that referenced this pull request Oct 25, 2019
@slevenick @JanMa
Add custom flatten to transform json to string -> string map for para…
273354a 
…ms (GoogleCloudPlatform#2467)

Merged PR GoogleCloudPlatform#2467.
JanMa added a commit to JanMa/magic-modules that referenced this pull request Oct 25, 2019
@JanMa
Revert "Add custom flatten to transform json to string -> string map …
b5ed79e 
…for params (GoogleCloudPlatform#2467)"

This reverts commit 273354a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tysen tysen tysen approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google_bigquery_data_transfer_config errors when using a bool with params attribute
4 participants
@slevenick @modular-magician @tysen @googlebot