Updates to generated id formats #2460

slevenick · 2019-10-10T22:48:04Z

Release Note Template for Downstream PRs (will be copied)

…work

modular-magician · 2019-10-11T17:56:57Z

3.0.0 diff report as of `be5b263`

compute, containeranalysis, filestore, healthcare, pubsub, redis, runtimeconfig, securityscanner, sourcerepo, spanner, sql, tpu

modular-magician · 2019-10-11T19:01:23Z

3.0.0 diff report as of `b18d8b3`

TPG Diff
TPGB Diff
Mapper Diff

slevenick · 2019-10-11T19:22:15Z

products/sql/terraform.yaml

    import_format: ["projects/{{project}}/instances/{{instance}}/databases/{{name}}",
                    "{{project}}/{{instance}}/{{name}}",
                    "instances/{{instance}}/databases/{{name}}",
-                    # support for a legacy import format


Do we need to note that we are no longer supporting this?

Probably worth adding, yeah.

rileykarson

These all look wrong:

google-beta/iam_runtime_config_config.go
google-beta/resource_container_analysis_note.go
google-beta/resource_healthcare_dataset.go

rileykarson · 2019-10-11T19:28:05Z

products/appengine/terraform.yaml

@@ -14,8 +14,8 @@
 --- !ruby/object:Provider::Terraform::Config
 overrides: !ruby/object:Overrides::ResourceOverrides
  FirewallRule: !ruby/object:Overrides::Terraform::ResourceOverride
-    id_format: "{{project}}/{{priority}}"
-    import_format: ["{{project}}/{{priority}}"]
+    id_format: "apps/{{project}}/firewall/ingressRules/{{priority}}"


Will #2461 make this + some other values redundant?

rileykarson · 2019-10-11T19:29:05Z

products/sql/terraform.yaml

    import_format: ["projects/{{project}}/instances/{{instance}}/databases/{{name}}",
                    "{{project}}/{{instance}}/{{name}}",
                    "instances/{{instance}}/databases/{{name}}",
-                    # support for a legacy import format


Probably worth adding, yeah.

modular-magician · 2019-10-11T20:47:27Z

3.0.0 diff report as of `e4b224e`

TPG Diff
TPGB Diff
Mapper Diff

rileykarson

Few more issues:

{{version_id}} replaced with {{name}} in google-beta/resource_app_engine_standard_app_version.go

Double entries (I suspect IAM is doing something silly for things that don't end in name? Idk:

google-beta/iam_binary_authorization_attestor.go
google-beta/iam_runtime_config_config.go

slevenick · 2019-10-11T22:31:36Z

Few more issues:

{{version_id}} replaced with {{name}} in google-beta/resource_app_engine_standard_app_version.go

Double entries (I suspect IAM is doing something silly for things that don't end in name? Idk:

google-beta/iam_binary_authorization_attestor.go

google-beta/iam_runtime_config_config.go

Ah, it's that our import format default doesn't handle query params (and is based off base_url instead of self_link). It's both binauth_iam and the regular resource. I'll add back the import_id for those

…. PR feedback

modular-magician · 2019-10-11T22:43:49Z

3.0.0 diff report as of `4e195b0`

TPG Diff
TPGB Diff
Mapper Diff

modular-magician · 2019-10-11T23:00:21Z

3.0.0 diff report as of `c9914da`

TPG Diff
TPGB Diff
Mapper Diff

modular-magician · 2019-10-11T23:12:14Z

3.0.0 diff report as of `ffddeb7`

TPG Diff
TPGB Diff
Mapper Diff

* Update ID fields for various MM-generated resources

* cloudbuild build trigger's trigger template should be required in 3.0.0. (#2352) * cloudbuild build trigger's trigger template should be required in 3.0.0. * Make backend_service.backends.group required. (#2373) * Remove Removed fields (#2391) * deprecated-->removed event notification config (#2390) * deprecated-->removed event notification config * remove singular config from tests/docs * pluralize * Update third_party/terraform/tests/resource_cloudiot_registry_test.go Co-Authored-By: Riley Karson <[email protected]> * Delete google_project_services in 3.0.0. (#2403) * Changing IAM audit config to be authoritative (#2438) * Changing IAM audit config to be authoritative * Remove unused code + test * Removing deprecated fields (#2436) * Add validation for scratch disks in Instance Template (#2282) * Add validation for scratch disks * Remove source from scratch disk * Use hardcoded image * Add reverse logic * Change default id format from {{name}} to self_link_uri (#2461) * Change default id format from {{name}} to self_link_uri * Updates to generated id formats (#2460) * Update ID fields for various MM-generated resources * gofmt -s -w extra file * Add userinfo.email to default scopes (#2473) * Set GKE Stackdriver defaults to GKE Stackdriver Monitoring (#2471) * only allow instance templates with 375gb scratch disks (#2495) * Update cloudfunction id for 3.0.0 release (#2501) * handle cloudfunctions deprecating nodejs6 (#2499) * Handwritten id updates for several compute resources (#2502) * Composer environment and compute attached disk id updates * Add compute instance * Add instance_from_group and instance_group * IGM id * Instance template tests passing * Add new id format to other calls of parseImportId in IGM * Small refactor to memoize var * Refactor, remove parseImportId in IGM * handle legacy network deprecation (#2508) * Fix gofmt diff in Cloud Functions (#2542) * More handwritten ids (#2527) * Fix cloudfunction formatting, migrate RIGM id * Update security policy resource id * Update target pool id format * Add new id for container cluster * Node pool id updates * PR feedback, using parseImportId for container resources * Formatting * fix container cluster (#2550) * Datasource id updates (#2544) * Update datasources * formatting * Even more handwritten ids (#2540) * Dataproc cluster, job, google project * Update sql ssl cert, database instance ids * Project id comparison include projects/ * remove kubernetes_dashboard from google_container_cluster (#2551) * Add back encoder that always sends autoCreateSubnetworks (#2558) * Allow defining empty taint, remove old DSF (#2537) * Remove encoder, can be done as send_empty_value on autoCreateSubnetworks (#2559) * deprecate 0.11 syntax in docs (datasources) (#2573) * deprecate 0.11 syntax in docs (resources) (#2574) * deprecate 0.11 syntax in docs (magic modules examples) (#2579) * remove long name behavior for pubsub subscriptions, clean up cu… (#2561) * remove long name behavior for pubsub subscriptions, clean up custom expanders * fix build * fix tests * Fix merge conflict in rigm test * Remove unused regexes from rigm (#2602) * Fix missing paren + bad var in resourcepolicy datasource 3.0.0 (#2600) * Test fixes based on integration tests, id formats + other easy fixes (#2605) * Test fixes based on integration tests, id formats + other easy fixes * Compute network id test update * Fix region disk test id * Update subnetwork to remove enable_flow_logs and depend on log_config instead (#2597) * Test updates to not depend on id format. Also test fixes (#2609) * Test updates to not depend on id format. Also test fixes * Typo * location -> region in node pool test * Cluster test fixes (#2611) * Fix container cluster tests, and signed url key, instance group * Fix invalid accessor * Update hand-written resources with `AtLeastOneOf` and `ExactlyOneOf` attributes (#2608) * Rigm/igm field removals for 3.0.0 (#2595) * Remove deprecated IGM fields for 3.0 * fix imports (#2619) * Remove automatic subnetwork creation in GKE (#2615) * Remove automatic subnetwork creation in GKE * Update docs, add Computed * More integration test fixes (#2617) * Fix bigtable for real, scratch disk size, target pool checks * Proxy test fixes * CloudIOT registry set removed field to nil. Add specific id format for access context manager * (r)igm imports for customdiff (#2623) * (r)igm imports for customdiff * Fix schema issues * Fix IGM custom diff and reuse method between resources (#2624) * Forwardingrule ip address (#2620) add the validation function * Remove unused sort import from rigm (#2625) * add composer test fixes, backend bucket signed url key (#2631) * Stop users from specifying bigquery-json in 3.0.0 (#2626) * Send null logConfig if subnetwork is L7ILB (#2635) * Send null logConfig if subnetwork is L7ILB * Move subnet ilb check to only if logConfig unspecified * deprecate 0.11 syntax in tests (datasources) (#2593) * Make master_authorized_networks_config.cidr_blocks Optional in… (#2642) * Make master_authorized_networks_config.cidr_blocks Optional in GKE * Add note * update magic module-generated resources with at_least_one_of (#2639) * add exactly_one_of to magic modules update comment * Update Data Fusion Instance to conform with 3.0.0 id updates (#2649) * Fix IAM doc id_format to new post 3.0.0 style * Add note on id format changes (#2656) * Add upgrade guide for subnetwork log_config (#2653) * Add upgrade guide for subnetwork log_config * Add examples for subnet logConfig update * Wording on upgrade guide * Add note on audit log config (#2658) * Add misc entries to the upgrade guide (#2657) * Add misc entries to the upgrade guide * Remove extra space * add info on scratch disk size and remove duplicate kms_key_self… (#2659) * Add upgrade guide notes. (#2663) * Add upgrade guide for forwarding rule validation (#2666) * Convert old import formats (using non-/) to use /. (#2638) * Convert old import formats (using non-/) to use /. * Upgrade proofreading (#2668) * Add upgrade note for IoT registry event_notification_configs (#2390) (#2651) Merged PR #2651. * sort upgrade guide; change wording in a few places * Password is not actually required. (#2670) * Add improved for_each non-module variant to project service upg… (#2671) * Update bigtable import & tests to 3.0 (#2673) * update upgrade guide (#2665) * update formatting for upgrade doc (#2674) * Add rigm to upgrade guide (#2667) Update docs to be accurate for 3.0 * proofreading changes (#2676) * Add back lost newlines

* Update ID fields for various MM-generated resources

googlebot added the cla: yes label Oct 10, 2019

slevenick added 12 commits October 11, 2019 10:32

Updating appengine firewall ID field, sample for more thorough 3.0.0 …

5a25c26

…work

Remove unneeded id format declaration instead

8c2369f

Fiddling with import id

4db967d

Updates for the rest of appengine

6506466

Updating bigquery id formats

3fd84d5

Fix extra quotes

3724208

Update bigtable resource ids

29d2819

Update binauth id formats

c2bea8e

Update cloudbuild id formats

2c6db23

Update cloudfunction id

0cc63ec

Update id formats for cloudrun

8f05a8f

Cloudscheduler, dns

fd99a05

slevenick force-pushed the appengine-firewall-id-update branch from 920a66f to fd99a05 Compare October 11, 2019 17:37

slevenick added 2 commits October 11, 2019 10:38

Removing unneeded id format declarations

f52ded5

Fix return vals

be5b263

Update id formats for generated resources in:

b18d8b3

compute, containeranalysis, filestore, healthcare, pubsub, redis, runtimeconfig, securityscanner, sourcerepo, spanner, sql, tpu

slevenick commented Oct 11, 2019

View reviewed changes

slevenick requested a review from rileykarson October 11, 2019 19:23

slevenick changed the title ~~Updates to appengine, bigquery, bigtable, cloudbuild, cloudfunctions, cloudrun id formats~~ Updates to generated id formats Oct 11, 2019

rileykarson reviewed Oct 11, 2019

View reviewed changes

slevenick added 2 commits October 11, 2019 13:27

Remove some redundant id formats as the default works in most cases

be762eb

Remove runtimeconfig unused var

e4b224e

rileykarson reviewed Oct 11, 2019

View reviewed changes

Fixes for appengine standard version, runtimeconfig, binauth attestor…

4e195b0

…. PR feedback

Fix binauth policy, bigquery dataset ids

c9914da

Last name issue, appengine firewall

ffddeb7

slevenick requested a review from rileykarson October 11, 2019 23:32

rileykarson approved these changes Oct 11, 2019

View reviewed changes

slevenick merged this pull request into GoogleCloudPlatform:3.0.0 Oct 14, 2019

rileykarson pushed a commit that referenced this pull request Oct 15, 2019

Updates to generated id formats (#2460)

c0f8511

* Update ID fields for various MM-generated resources

rileykarson pushed a commit that referenced this pull request Oct 24, 2019

Updates to generated id formats (#2460)

bf17738

* Update ID fields for various MM-generated resources

rileykarson pushed a commit that referenced this pull request Nov 6, 2019

Updates to generated id formats (#2460)

f4b9310

* Update ID fields for various MM-generated resources

slevenick added a commit that referenced this pull request Nov 6, 2019

Updates to generated id formats (#2460)

bdbcca4

* Update ID fields for various MM-generated resources

slevenick added a commit that referenced this pull request Nov 7, 2019

Updates to generated id formats (#2460)

e5f2c4b

* Update ID fields for various MM-generated resources

rileykarson pushed a commit that referenced this pull request Nov 11, 2019

Updates to generated id formats (#2460)

3b43698

* Update ID fields for various MM-generated resources

slevenick added a commit that referenced this pull request Nov 12, 2019

Updates to generated id formats (#2460)

cacdb91

* Update ID fields for various MM-generated resources

rileykarson pushed a commit that referenced this pull request Nov 13, 2019

Updates to generated id formats (#2460)

e414c84

* Update ID fields for various MM-generated resources

rileykarson pushed a commit that referenced this pull request Nov 13, 2019

Updates to generated id formats (#2460)

5204c70

* Update ID fields for various MM-generated resources

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates to generated id formats #2460

Updates to generated id formats #2460

slevenick commented Oct 10, 2019

modular-magician commented Oct 11, 2019

modular-magician commented Oct 11, 2019

slevenick Oct 11, 2019

rileykarson Oct 11, 2019

rileykarson left a comment

rileykarson Oct 11, 2019

rileykarson Oct 11, 2019

modular-magician commented Oct 11, 2019

rileykarson left a comment

slevenick commented Oct 11, 2019

modular-magician commented Oct 11, 2019

modular-magician commented Oct 11, 2019

modular-magician commented Oct 11, 2019

Updates to generated id formats #2460

Updates to generated id formats #2460

Conversation

slevenick commented Oct 10, 2019

modular-magician commented Oct 11, 2019

3.0.0 diff report as of be5b263

modular-magician commented Oct 11, 2019

3.0.0 diff report as of b18d8b3

slevenick Oct 11, 2019

Choose a reason for hiding this comment

rileykarson Oct 11, 2019

Choose a reason for hiding this comment

rileykarson left a comment

Choose a reason for hiding this comment

rileykarson Oct 11, 2019

Choose a reason for hiding this comment

rileykarson Oct 11, 2019

Choose a reason for hiding this comment

modular-magician commented Oct 11, 2019

3.0.0 diff report as of e4b224e

rileykarson left a comment

Choose a reason for hiding this comment

slevenick commented Oct 11, 2019

modular-magician commented Oct 11, 2019

3.0.0 diff report as of 4e195b0

modular-magician commented Oct 11, 2019

3.0.0 diff report as of c9914da

modular-magician commented Oct 11, 2019

3.0.0 diff report as of ffddeb7

3.0.0 diff report as of `be5b263`

3.0.0 diff report as of `b18d8b3`

3.0.0 diff report as of `e4b224e`

3.0.0 diff report as of `4e195b0`

3.0.0 diff report as of `c9914da`

3.0.0 diff report as of `ffddeb7`