Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Cloud Run DomainMapping namespace in encoder #2458

Merged

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Oct 10, 2019

Fixes hashicorp/terraform-provider-google#4651

The correct namespace (apiVersion) for DomainMapping is domains.cloudrun.com/v1alpha1. Previously, the value was ignored but now it's being validated.

        "fieldViolations": [
          {
            "field": "api_version",
            "description": "Unsupported API version 'serving.knative.dev/v1alpha1'"
          }
        ]

Release Note Template for Downstream PRs (will be copied)

cloudrun: fixed the apiVersion sent in `google_cloud_run_domain_mapping` requests

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b81b4cd.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1251
depends: GoogleCloudPlatform/terraform-google-conversion#226
depends: hashicorp/terraform-provider-google#4657

@rileykarson
Copy link
Member Author

Regenerating so the Magician is less noisy.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b81b4cd.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/inspec-gcp#231

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b81b4cd.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

rileykarson and others added 2 commits October 10, 2019 21:45
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 6cd5b8b into GoogleCloudPlatform:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_cloud_run_domain_mapping is broken
4 participants