Implement basepath patches in the provider. #2443
Conversation
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in Ansible. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
| @@ -108,7 +108,7 @@ func getInstanceReferences(instanceUrls []string) (refs []*compute.InstanceRefer | |||
|
|
|||
| func validInstanceURLs(instanceUrls []string) bool { | |||
| for _, v := range instanceUrls { | |||
| if !strings.HasPrefix(v, "https://www.googleapis.com/compute/v1/") { | |||
| if !strings.HasPrefix(v, "https://") { | |||
There was a problem hiding this comment.
What do we expect in instanceUrls that is NOT a valid instance URL?
There was a problem hiding this comment.
It's a user-provided value, so we'd expect names or partial URIs instead of self links, which are expected by the API. It's way more likely that users will do that than mistype compute or something. If we checked the base path value, we'd error on (perfectly usable!) URLs for other versions here.
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
modular-magician
force-pushed
the
basepaths
branch
from
c5a63e2 to
59a2e75
Compare
Fixes hashicorp/terraform-provider-google#4504, doesn't need to happen for
3.0.0- this should all be compatible.Release Note Template for Downstream PRs (will be copied)