Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom flattens for passwords #2376

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Add custom flattens for passwords #2376

merged 2 commits into from
Oct 8, 2019

Conversation

tysen
Copy link

@tysen tysen commented Sep 25, 2019

Fixes hashicorp/terraform-provider-google#4542

Release Note Template for Downstream PRs (will be copied)

fixed perma-diff in `google_security_scanner_scan_config`

@tysen tysen requested a review from slevenick September 25, 2019 19:40
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 8d2449b.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#4548

@tysen tysen changed the title Marks passwords as ignore_read in scan configs Add custom flattens for passwords Oct 2, 2019
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b7eb8da.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1230

Ty Larrabee and others added 2 commits October 8, 2019 18:55
@modular-magician
Add custom flatteners for auth passwords.
ceb619e
@modular-magician
Update tracked submodules -> HEAD on Tue Oct 8 18:55:53 UTC 2019
b3f4372 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 13ea31a into GoogleCloudPlatform:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slevenick slevenick slevenick approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google_security_scanner_scan_config always requires recreation
4 participants
@tysen @modular-magician @slevenick @googlebot