Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update/organize sidebar #2333

Merged
merged 3 commits into from
Sep 17, 2019

Conversation

danawillow
Copy link
Contributor

Release Note for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 504e8e9.

Pull request statuses

WARNING: The following files changed in commit 504e8e9 may need corresponding changes in third_party/validator:

  • third_party/terraform/utils/iam_project.go

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1148
depends: hashicorp/terraform-provider-google#4472

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, a92e38e.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1151
depends: hashicorp/terraform-provider-google#4475

@danawillow
Copy link
Contributor Author

@rileykarson, should the new VPC entry be where it is or with Access Context Manager (which also mentions VPC)?

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think where it is. It's not clear to me what the relation between VPC Service Controls and VPC / Serverless VPC Access are.

FWIW, the VPC product's sole resource is from the vpcaccess service / Serverless VPC Access API, although the parent product is called VPC, confusingly. I'm slightly more in favour of calling the section Serverless VPC Access to avoid confusion with VPC Network in GCE.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 643a0fd.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit c031961 into GoogleCloudPlatform:master Sep 17, 2019
@danawillow danawillow deleted the sidebar branch September 18, 2019 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants