Fix partially defined operation timeout blocks' default values #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-provider-google-beta. New Pull RequestsI didn't open any new pull requests because of this PR. |
emilymye
approved these changes
Sep 16, 2019
modular-magician
force-pushed
the
fix-timeouts-defaults
branch
from
9bdea7c to
506cef2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered in #2228
If a user partially defines an
Api::Timeoutsblock in their operation, it never gets a default value and later generates invalid code. Thevalidatefn on the object fills in defaults, so we need to runvalidate.Release Note for Downstream PRs (will be copied)