New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add beta fields to BackendService to support traffic director #2288

Merged

modular-magician merged 3 commits into GoogleCloudPlatform:master from tysen:traffic-director

Sep 19, 2019

tysen commented Sep 5, 2019

Release Note for Downstream PRs (will be copied)

`google_compute_backend_service` now supports `locality_lb_policy`, `outlier_detection`, `consistent_hash`, and `circuit_breakers`.

tysen added the changelog: enhancement label

tysen requested a review from rileykarson

September 5, 2019 19:28

googlebot added the cla: yes label

Collaborator

modular-magician commented Sep 5, 2019 •

edited by tysen

Loading

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of c79ec8eb0191c63f2f9f5c5bc4aa96787d198572.

Pull request statuses

No diff detected in terraform-google-conversion.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1118
depends: hashicorp/terraform-provider-google#4412
depends: modular-magician/inspec-gcp#196

modular-magician added downstream-generated ansible inspec terraform-provider-google-beta terraform-provider-google labels

rileykarson requested changes

View reviewed changes

Member

rileykarson left a comment

Wow, this is a lot of fields! I have a bunch of nitpicks so far and I'd prefer if we added another example + update test.

products/compute/api.yaml Show resolved Hide resolved

products/compute/api.yaml Outdated Show resolved Hide resolved

products/compute/api.yaml Show resolved Hide resolved

products/compute/api.yaml Outdated Show resolved Hide resolved

products/compute/api.yaml Show resolved Hide resolved

products/compute/api.yaml Outdated Show resolved Hide resolved

templates/terraform/examples/backend_service_traffic_director.tf.erb Outdated Show resolved Hide resolved

products/compute/terraform.yaml Show resolved Hide resolved

third_party/terraform/tests/resource_compute_backend_service_test.go.erb Outdated

    
            @@ -752,6 +752,132 @@ func TestAccComputeBackendService_internalLoadBalancing(t *testing.T) {
          
              }

              <% end -%>

              <% unless version == 'ga' -%>

              func TestAccComputeBackendService_trafficDirectorUpdate(t *testing.T) {

Member

rileykarson Sep 5, 2019

Can you add a second update test that updates from testAccComputeBackendService_trafficDirector to a config where the localityLbPolicy is one of the simpler ones (and so all the hash stuff is completely unset)? Preferably a different one than the example.

Author

tysen Sep 16, 2019

I added this and since the API doesn't handle the removal of consistentHash very well, I made localityLbPolicy input only.

third_party/terraform/tests/resource_compute_backend_service_test.go.erb Outdated Show resolved Hide resolved

tysen requested a review from rileykarson

September 16, 2019 22:04

rileykarson approved these changes

View reviewed changes

Collaborator

modular-magician commented Sep 16, 2019

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, ed8b304.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
InSpec already has an open PR.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: ansible-collections/google.cloud#6

Collaborator

modular-magician commented Sep 17, 2019

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, a8cfcbc.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

Collaborator

modular-magician commented Sep 18, 2019

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 71a04cb.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

Collaborator

modular-magician commented Sep 18, 2019

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, e92d2f3.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

Collaborator

modular-magician commented Sep 19, 2019

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5f8a310.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

Collaborator

modular-magician commented Sep 19, 2019

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, ed58b56.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician added the automerged label

Ty Larrabee and others added 3 commits

September 19, 2019 22:09


          Add beta fields to BackendService to support traffic director

02fdeb6


          Add more tests for traffic director

2b96bb6


          Update tracked submodules -> HEAD on Thu Sep 19 22:09:56 UTC 2019

241c491

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician merged commit 54a90c5 into GoogleCloudPlatform:master

This was referenced Oct 2, 2019

New GCP module: gcp_compute_node_template ansible/ansible#63064

Merged

New GCP module: gcp_compute_node_template_info ansible/ansible#63065

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ansible automerged cla: yes downstream-generated inspec terraform-provider-google terraform-provider-google-beta