-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added some fileds to CloudRun status #2185
added some fileds to CloudRun status #2185
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs. Thanks for your contribution! A human will be with you soon. @rileykarson, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the conditions that url
and latestReadyRevisionName
will be set? I can see the other 2 fields in the status of our existing tests, but not those.
@rileykarson I guess it's set after the app becomes ready. CloudRun deployments are somehow asynchronous (like |
I'm not thrilled about fields that get set out of band like that, but that's more a gripe with the API than anything else. Filed hashicorp/terraform-provider-google#4335 for an improvement to Cloud Run behaviour. |
13c22a3
to
b32c224
Compare
I added some fields to CloudRun status, namely
Release Note for Downstream PRs (will be copied)