Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some fileds to CloudRun status #2185

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

tmshn
Copy link
Contributor

@tmshn tmshn commented Aug 15, 2019

I added some fields to CloudRun status, namely

  • url
  • observedGeneration
  • latestCreatedRevisionName
  • latestReadyRevisionName

Release Note for Downstream PRs (will be copied)

New output-only fields have been added to google_cloud_run_service' status.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 13c22a3.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1071

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the conditions that url and latestReadyRevisionName will be set? I can see the other 2 fields in the status of our existing tests, but not those.

@tmshn
Copy link
Contributor Author

tmshn commented Aug 24, 2019

@rileykarson I guess it's set after the app becomes ready. CloudRun deployments are somehow asynchronous (like kubectl apply), these fields are blank on first apply. If you run terraform apply or terraform refresh after the app becomes ready, you can see actual value of them.
(Similarly, all of status.conditions[*].status is "Unknown" on a first apply, but becomes "True" on next refresh).

@rileykarson
Copy link
Member

I'm not thrilled about fields that get set out of band like that, but that's more a gripe with the API than anything else. Filed hashicorp/terraform-provider-google#4335 for an improvement to Cloud Run behaviour.

@modular-magician modular-magician merged commit 4480ffe into GoogleCloudPlatform:master Aug 26, 2019
@tmshn tmshn deleted the cloudrun-status branch August 29, 2019 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants