Unbreak IAM. #2180
Unbreak IAM. #2180
Conversation
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
third_party/terraform/utils/iam.go
Outdated
| // <type> is case sensitive | ||
| // <value> isn't | ||
| // so let's lowercase the value and leave the type alone | ||
| pieces := strings.Split(m, ":") |
There was a problem hiding this comment.
is it possible that the member could have a : in it? If so, I think SplitN or something like that will make it so that you only split on the first occurrence.
There was a problem hiding this comment.
This is a good point! PR updated to use SplitN. Still look good?
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
1 similar comment
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
I tried to reintroduce case-insensitivity for members in IAM in GoogleCloudPlatform#2168, but apparently only _part_ of the members value is case-insensitive. Members values are in the format `<type>:<value>` where `<type>` is something like `user` and `<value>` is something like `[email protected]`. The _value_ is case-insensitive, but the _type_ is very much case-sensitive, and broke a bunch of our tests, namely for the `serviceAccount` type. This fixes it by only changing the case of the value, not the whole string.
In case values have a `:` in them.
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
paddy_unbreak_iam
branch
from
ac531e3 to
c897762
Compare
I tried to reintroduce case-insensitivity for members in IAM in #2168,
but apparently only part of the members value is case-insensitive.
Members values are in the format
<type>:<value>where<type>issomething like
userand<value>is something like[email protected]. The value is case-insensitive, but the typeis very much case-sensitive, and broke a bunch of our tests, namely for
the
serviceAccounttype.This fixes it by only changing the case of the value, not the whole
string.
Release Note for Downstream PRs (will be copied)