Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle domain-scoped projects with GCR #2169

Merged
merged 2 commits into from
Aug 15, 2019
Merged

Correctly handle domain-scoped projects with GCR #2169

merged 2 commits into from
Aug 15, 2019

Conversation

danawillow
Copy link
Contributor

Upstreams hashicorp/terraform-provider-google#4129 (review)

Release Note for Downstream PRs (will be copied)

containerregistry: Correctly handle domain-scoped projects

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 9f910f9355745560838658f75ecb2ae5390ebdce.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1035
depends: hashicorp/terraform-provider-google#4238

@danawillow danawillow requested a review from emilymye August 13, 2019 23:07
@danawillow
Copy link
Contributor Author

Ping @emilymye (this is just an upstreaming so it's already been reviewed)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 09f492b.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 09f492b.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#4266

kevinmdavis and others added 2 commits August 15, 2019 20:55
@kevinmdavis @modular-magician
Replace the ':' in project IDs with '/' when constructing gcr.io URLs…
6e720e2 
…. This is necessary to work correctly with domain-scoped projects in GCR: https://cloud.google.com/container-registry/docs/overview#domain-scoped_projects
@modular-magician
Update tracked submodules -> HEAD on Thu Aug 15 20:55:49 UTC 2019
ff13ce5 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 9adb665 into GoogleCloudPlatform:master Aug 15, 2019
@danawillow danawillow deleted the tf-4129 branch August 15, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilymye emilymye emilymye approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danawillow @modular-magician @emilymye @googlebot @kevinmdavis