Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make key_name optional in container_cluster.database_encryption #2163

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Conversation

tysen
Copy link

@tysen tysen commented Aug 13, 2019

Fixes hashicorp/terraform-provider-google#3998

Release Note for Downstream PRs (will be copied)

`key_name` in `google_container_cluster.database_encryption` is no longer a required field.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of ec786a1.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1032

Ty Larrabee and others added 2 commits August 13, 2019 21:03
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 416603f into GoogleCloudPlatform:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

database_encryption block has key_name field as required. The computed value from GKE is actually empty.
4 participants