Allow the use of region selflinks in provider configs. #2156
Conversation
When configuring the provider, currently we only accept the name of a region. As per hashicorp/terraform-provider-google#4133, being able to use self_links for regions here would be helpful. I added a utility function to pull the region's name from a self_link, tests for that behavior, and then used it when setting up our Config object. It'll either return what the user passed in, or if it recognizes it as a region self_link, it'll just return the name part of the region. I also left it open to expand on potentially more formats in the future.
paddycarver
force-pushed
the
paddy_provider_region_retry_final_FINAL_final
branch
from
963d3f1 to
bac88ac
Compare
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in Ansible. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
1 similar comment
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
When configuring the provider, currently we only accept the name of a
region. As per hashicorp/terraform-provider-google#4133, being
able to use self_links for regions here would be helpful. I added a
utility function to pull the region's name from a self_link, tests for
that behavior, and then used it when setting up our Config object. It'll
either return what the user passed in, or if it recognizes it as a
region self_link, it'll just return the name part of the region. I also
left it open to expand on potentially more formats in the future.
Release Note for Downstream PRs (will be copied)