remove compute API usage in third_party/validator/compute_instance.go

[yukinying]

Release Note for Downstream PRs (will be copied)

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

[danawillow]

Thanks @yukinying! Could you also make these changes in third_party/terraform/resources/resource_compute_instance.go? From what I understand, the expanders in the two files should be identical.

[yukinying]

I don't have a ruby dev environment handy so the changes on 3301427 are not tested. The previous one I have is already teared down. I planned to setup one again and test it. If the travis-ci test is reliable then I may skip the integration test in my local env.

[danawillow]

Ok! I'm starting off a magician run, which will generate the downstreams. That'll also tell us whether the code builds. From there, I can run one of the existing tests to confirm that this works (I don't think it merits any new ones).

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 3301427.

Pull request statuses

WARNING: The following files changed in commit 3301427 may need corresponding changes in third_party/validator:

• third_party/terraform/resources/resource_compute_instance.go

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1046
depends: GoogleCloudPlatform/terraform-google-conversion#162
depends: hashicorp/terraform-provider-google#4256

[danawillow]

Looks like the generated code doesn't build: https://travis-ci.org/terraform-providers/terraform-provider-google-beta/builds/571997297?utm_source=github_status&utm_medium=notification

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, a62867d.

Pull request statuses

WARNING: The following files changed in commit a62867d may need corresponding changes in third_party/validator:

• third_party/terraform/resources/resource_compute_instance.go

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 01ef2a6.

Pull request statuses

WARNING: The following files changed in commit 01ef2a6 may need corresponding changes in third_party/validator:

• third_party/terraform/resources/resource_compute_instance.go

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[yukinying]

I have update the code last night. PTAL. Thanks!

[danawillow]

Looks good!