Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compute_network_endpoint_group datasource #2112

Merged
merged 3 commits into from
Aug 7, 2019
Merged

Add compute_network_endpoint_group datasource #2112

merged 3 commits into from
Aug 7, 2019

Conversation

bpineau
Copy link
Contributor

@bpineau bpineau commented Jul 29, 2019 •
edited by emilymye
Loading

Release Note for Downstream PRs (will be copied)

`google_compute_network_endpoint_group`

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@slevenick slevenick requested a review from rambleraptor August 6, 2019 19:23
@rambleraptor rambleraptor requested review from emilymye and removed request for rambleraptor August 6, 2019 19:26
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 2d7660c.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#999
depends: GoogleCloudPlatform/terraform-google-conversion#146
depends: hashicorp/terraform-provider-google#4173

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 1bf4423.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

bpineau and others added 3 commits August 7, 2019 17:47
@bpineau @modular-magician
Add compute_network_endpoint_group datasource
057c8a9
@bpineau @modular-magician
NEG datasource documentation fixes
598f806 
Per review feedback.
Also, move that doc to the proper location (under d/ subdir).
@modular-magician
Update tracked submodules -> HEAD on Wed Aug 7 17:47:10 UTC 2019
ee499c4 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the datasource_google_compute_network_endpoint_group branch from 1bf4423 to ee499c4 Compare August 7, 2019 17:47
@modular-magician modular-magician merged commit 5795ea7 into GoogleCloudPlatform:master Aug 7, 2019
@emilymye emilymye mentioned this pull request Dec 13, 2019
Closed
@GusPrice GusPrice mentioned this pull request Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilymye emilymye emilymye approved these changes

Assignees
No one assigned
Labels
automerged cla: yes community downstream-generated terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bpineau @modular-magician @emilymye @googlebot