Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary Authorization: globalPolicyEvaluationMode #2111

Merged

Conversation

drebes
Copy link
Member

@drebes drebes commented Jul 28, 2019

Release Note for Downstream PRs (will be copied)

Adds `globalPolicyEvaluationMode` to `google_binary_authorization_policy`.

Fixes hashicorp/terraform-provider-google#4104

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 74c80b4.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#987
depends: GoogleCloudPlatform/terraform-google-conversion#137
depends: hashicorp/terraform-provider-google#4124

@danawillow
Copy link
Contributor

I don't love that there isn't a test that covers this field. Could you add it to TestAccBinaryAuthorizationPolicy_full?

@drebes
Copy link
Member Author

drebes commented Aug 6, 2019

Of course, Will do it.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, d1a3b04.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, d41334b.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@drebes
Copy link
Member Author

drebes commented Aug 6, 2019

Should be good now, CI seems to be failing related to github connectivity, but local tests pass.

$ make testacc TEST=./google-beta TESTARGS='-run=TestAccBinaryAuthorizationPolicy' 
==> Checking source code against gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google-beta -v -run=TestAccBinaryAuthorizationPolicy -timeout 240m -ldflags="-X=github.com/terraform-providers/terraform-provider-google-beta/version.ProviderVersion=acc"
=== RUN   TestAccBinaryAuthorizationPolicy_basic
=== PAUSE TestAccBinaryAuthorizationPolicy_basic
=== RUN   TestAccBinaryAuthorizationPolicy_full
=== PAUSE TestAccBinaryAuthorizationPolicy_full
=== RUN   TestAccBinaryAuthorizationPolicy_separateProject
=== PAUSE TestAccBinaryAuthorizationPolicy_separateProject
=== RUN   TestAccBinaryAuthorizationPolicy_update
=== PAUSE TestAccBinaryAuthorizationPolicy_update
=== CONT  TestAccBinaryAuthorizationPolicy_basic
=== CONT  TestAccBinaryAuthorizationPolicy_update
=== CONT  TestAccBinaryAuthorizationPolicy_separateProject
=== CONT  TestAccBinaryAuthorizationPolicy_full
--- PASS: TestAccBinaryAuthorizationPolicy_basic (27.77s)
--- PASS: TestAccBinaryAuthorizationPolicy_full (161.57s)
--- PASS: TestAccBinaryAuthorizationPolicy_separateProject (161.82s)
--- PASS: TestAccBinaryAuthorizationPolicy_update (178.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google-beta/google-beta	178.912s

@modular-magician modular-magician merged commit abb75df into GoogleCloudPlatform:master Aug 6, 2019
@drebes drebes deleted the binauth-globalpolicy branch March 13, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GlobalPolicyEvaluationMode (Binary Authorization)
5 participants