Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for user-defined labels on dataflow_job resource #2093

Merged

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Jul 24, 2019

added support for user-defined labels on dataflow_job resource

Release Note for Downstream PRs (will be copied)

added support for user-defined `labels` on resource `google_dataflow_job`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 255abed.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#970
depends: hashicorp/terraform-provider-google#4095
depends: modular-magician/ansible#324

@megan07 megan07 changed the title Megan dataflow labels add support for user-defined labels on dataflow_job resource Jul 24, 2019
@megan07 megan07 requested a review from danawillow July 24, 2019 16:10
Subnetwork: d.Get("subnetwork").(string),
TempLocation: d.Get("temp_gcs_location").(string),
MachineType: d.Get("machine_type").(string),
AdditionalUserLabels: labels,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, d6fafed.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@megan07 megan07 requested a review from danawillow July 25, 2019 16:59
megan07 and others added 4 commits July 26, 2019 15:22
@modular-magician modular-magician merged commit 8961223 into GoogleCloudPlatform:master Jul 26, 2019
@SarahFrench SarahFrench deleted the megan_dataflow_labels branch March 26, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants