Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require master_ipv4_cidr_block if enable_private_nodes is true #2063

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Conversation

tysen
Copy link

@tysen tysen commented Jul 17, 2019

Fixes hashicorp/terraform-provider-google#3981

Release Note for Downstream PRs (will be copied)


@tysen tysen requested a review from danawillow July 17, 2019 00:02
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of cb1d86f.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#948
depends: hashicorp/terraform-provider-google#4038

Ty Larrabee and others added 2 commits July 17, 2019 18:41
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 5ef00b5 into GoogleCloudPlatform:master Jul 17, 2019
@tysen tysen deleted the nodes-error branch July 17, 2019 18:43
@WillBeebe
Copy link

This caused our Kubernetes deploy to fail. We're passing in this property but the run failed, so we've pinned at the provider without this change. What can I provide to help debug this?

@tysen
Copy link
Author

tysen commented Aug 5, 2019

The relevant output of TF_LOG=DEBUG terraform apply would help.

@rileykarson
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear error 400 on creating private cluster: (cluster.master_ipv4_cidr causes http 400)
6 participants