Support delete for network peering #2038
Conversation
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
|
|
||
| res, err := sendRequestWithTimeout(config, "POST", url, obj, d.Timeout(schema.TimeoutUpdate)) | ||
| if err != nil { | ||
| return fmt.Errorf("Error removing connection from network %s: %s", d.Id(), err) |
There was a problem hiding this comment.
handleNotFoundError maybe?
| parentService := "services/" + parent | ||
| networkName := fmt.Sprintf("projects/%s/global/networks/%s", project, network) | ||
|
|
||
|
|
chrisst
force-pushed
the
delete-network-peering
branch
from
de5a811 to
6417766
Compare
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Change Read to remove from state instead of erroring if not found. Added the 'peering' computed filed to use as a reference key for calls to the networking resources. Support Delete by calling 'removePeering' on the associated Network
modular-magician
force-pushed
the
delete-network-peering
branch
from
6417766 to
6d993ba
Compare
Refactor service networking connection
Change Read to remove from state instead of erroring if not found.
Added the 'peering' computed filed to use as a reference key for calls to the
networking resources.
Support Delete by calling 'removePeering' on the associated Network
fixes hashicorp/terraform-provider-google#3979
Release Note for Downstream PRs (will be copied)