New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansible Markdown Parser #1938

Closed

rambleraptor wants to merge 13 commits into master from markdown-parser

Contributor

rambleraptor commented Jun 19, 2019

We've talked in the past about how we should assume all descriptions are Markdown.

This is a proper Markdown parser for the Ansible docs. It takes in Markdown (the Markdown types I've seen directly in api.yaml so far) and converts it to an Ansible text description.

My goal right now is to get the docs as close as possible. There will be future changes to make things look nicer, but the goal is to make this large diff more palatable.

googlebot added the cla: yes label

rambleraptor force-pushed the markdown-parser branch 2 times, most recently from a348a6f to 77da540 Compare

June 19, 2019 17:42

Collaborator

modular-magician commented Jun 19, 2019

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 77da540.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/ansible#284

modular-magician added downstream-generated ansible labels

Collaborator

modular-magician commented Jun 19, 2019

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 650a477.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

1 similar comment

Collaborator

modular-magician commented Jun 19, 2019

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 650a477.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Collaborator

modular-magician commented Jun 19, 2019

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 253a5bc.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

rambleraptor added 9 commits

June 19, 2019 13:12


          adding redcarpet to Gemfile

b5a7277


          markdown parser

e4626c3


          url formatting + better line splitting

cec5db2


          dont split lines

35b1101


          adding new gemfile to container

f0ff799


          more container changes

f01f42d


          rubocop

2afd0eb


          fixes

c5d5e95


          removing spaces

ee15a7d

rambleraptor force-pushed the markdown-parser branch from 82331d0 to caf5936 Compare

June 19, 2019 20:13


          array differences

05e7916

rambleraptor force-pushed the markdown-parser branch from caf5936 to 05e7916 Compare

June 19, 2019 20:22

Collaborator

modular-magician commented Jun 19, 2019

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 82331d0.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.


          markdown

cfaa708

rambleraptor force-pushed the markdown-parser branch from 6bfbe97 to cfaa708 Compare

June 19, 2019 20:55

Collaborator

modular-magician commented Jun 19, 2019

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, cfaa708.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.


          removing some special symbols to make the parser happy

2e2fa84

Collaborator

modular-magician commented Jun 19, 2019

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 2e2fa84.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#868

modular-magician added the terraform-provider-google-beta label


          adding in quotes

72fa91d

rambleraptor closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ansible cla: yes downstream-generated terraform-provider-google-beta