Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max_connection/rate_per_endpoint to backend services #1928

Merged

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Jun 17, 2019

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 721a9a7.

Pull request statuses

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#854
depends: GoogleCloudPlatform/terraform-google-conversion#110
depends: hashicorp/terraform-provider-google#3863
depends: modular-magician/ansible#280
depends: modular-magician/inspec-gcp#164

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if the API allows updating either of these to be zero? If so, I think you'll need to add send_empty_values to api.yaml

products/compute/api.yaml Show resolved Hide resolved
products/compute/api.yaml Show resolved Hide resolved
@emilymye
Copy link
Contributor Author

emilymye commented Jun 18, 2019

@danawillow Added send empty values for all the fields (the total capacity can't be zero, but if you have two backends you can set one to 0)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, e3bcfe9.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

products/compute/terraform.yaml Outdated Show resolved Hide resolved
@emilymye emilymye force-pushed the neg_backend_service branch from 2edf47a to 19f3baf Compare June 19, 2019 19:31
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 19f3baf.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing field 'MaxRatePerEndpoint' which makes it difficult to manage NEG
4 participants