-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add max_connection/rate_per_endpoint to backend services #1928
Add max_connection/rate_per_endpoint to backend services #1928
Conversation
emilymye
commented
Jun 17, 2019
•
edited
Loading
edited
- Fixes Missing field 'MaxRatePerEndpoint' which makes it difficult to manage NEG hashicorp/terraform-provider-google#3296 (and finishes rest of NEG work for now)
- Also, add self_link to NEG so it can be referenced in backend services or otherwise
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNew Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if the API allows updating either of these to be zero? If so, I think you'll need to add send_empty_values to api.yaml
@danawillow Added send empty values for all the fields (the total capacity can't be zero, but if you have two backends you can set one to 0) |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
2edf47a
to
19f3baf
Compare
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.