-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firestore API: Add COLLECTION_GROUP to queryScope #1920
Firestore API: Add COLLECTION_GROUP to queryScope #1920
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs. Thanks for your contribution! A human will be with you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Do you mind updating the description
The scope at which a query is run. Defaults to `"COLLECTION"`.
to this?
The scope at which a query is run. One of `"COLLECTION"` or `"COLLECTION_GROUP"`. Defaults to `"COLLECTION"`.
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
2a5aa3c
to
ab44cd8
Compare
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
Collection group scope was recently added to Cloud Firestore indexes.
Here is an example of one pulled with
gcloud
CLI:Notice that
QUERY_SCOPE
has a value ofCOLLECTION_GROUP
which is a valid option for this parameter.See also Firestore release notes for May 7 2019: https://cloud.google.com/firestore/docs/release-notes