Add terraform support for external vpn gateway #1901
Conversation
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in Ansible. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
templates/terraform/resource.erb
Outdated
| if err := d.Set("self_link", ConvertSelfLinkToV1(res["selfLink"].(string))); err != nil { | ||
| <% else -%> | ||
| if err := d.Set("self_link", ConvertSelfLinkToBeta(res["selfLink"].(string))); err != nil { |
There was a problem hiding this comment.
Is this going to be a breaking change for all the beta resources that have been using the v1 self link?
There was a problem hiding this comment.
The pattern has been to convert to V1 even if the resource was created/read using the beta provider so that we don't end up with diffs on resources that interpolate that field. Does something not work without this, or was it just a notice-with-your-eyes thing?
There was a problem hiding this comment.
Executing a test that creates and references an external VPN gateway within a VPN tunnel was failing. The API is returning the full resource link beta/projects... which was diffing with the self_link exported by the external_gateway resource.
Maybe I need a custom expander on the tunnel read action that converts to V1?
There was a problem hiding this comment.
Ah, you probably want a ResourceRef on the external gateway field of the tunnel resource- the templates should kick in at that point to do all the appropriate URL stuff
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
slevenick
force-pushed
the
external-vpn-gateway
branch
from
044807d to
a864a54
Compare
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
external-vpn-gateway
branch
from
a864a54 to
fedb787
Compare
Add terraform support for external vpn gateway